Integrate retire.js into GitHub Actions CI#56
Merged
Conversation
Author
|
Retire.js is integrated into the CI. However, it's currently failing certain checks (exit code 13). There are currently a couple libraries with severity=medium that are being caught by the tool. Do we want to customize to set it to only catch severity=high for now? |
grunt-contrib-watch wasn't being used but was failing retire.js, so uninstalled it.
|
I looked through the code and everything seems logical. Code also seems to be passing all of the tests, feel free to push! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the Retire.js static analysis tool into the GitHub Actions CI. Information about retire.js and NodeBB can found here. .
Note: Currently, retire.js runs with
--severity high. In the future, fix the medium and low severity issues, and change the command to justretirein order to identify all security risks.